LiveView fix - Continuing work done in #20 #27
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get set_locale working with Phoenix LiveView, we need to put the locale into the session
The conn ended up missing :locale assign, so used the pipe operator there. Also added tests to see if the session actually contains the locale.
|
bump. is this branch the way to go currently? edit: currently this doesn't work. gives error. |
Author
|
I think the Plug.Conn compilation error is because we have to define either cowboy or bandit as a dependency now to use Plug. (I'm not completely sure here though) Tried to update this branch to use the latest version of Phoenix (to get it even to compile on my machine), but I have 18 tests failing now, and I'm not currently using this library so I don't think I'll have time to fix everything going wrong there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #20, so thanks for raerkeer for starting the task.
The conn ended up missing :locale assign, so used the pipe operator
there. Also added tests to see if the session actually contains the
locale.